Skip to content

Fix Firestore Browser tests #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2019
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

This is the set of changes I needed to run yarn test:browser in packages/firestore.

Notes:

  • forEachType is unused so I optimized for code size.
  • I don't know how to properly depend on the newest set of Firestore types, which are needed to expose onSnapshotsInSync (cc @Feiyang1)

@@ -30,7 +30,7 @@
"dist"
],
"dependencies": {
"@firebase/firestore-types": "1.5.0",
"@firebase/firestore-types": "file:../firestore-types/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to manually change package version. Lerna will make the new types available to all packages in the workspace in our dev environment.

Package versions are automatically updated by the release script during a release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree in principle, but in practice, yarn test:browser is failing from packages/firestore. 😄 It seems like with our current setup we have a period of brokenness between when we check in a change to firestore-types and when we do the next release. Any suggestions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just rm -rf node_modules and re-installed. I am now getting a node_modules/@firebase/firestore-types/index.d.ts that contains onSnapshotsInSync. I will remove this change from the PR.

Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the right thing to do for the package version is. I'll defer to @Feiyang1 for that. The other change LGTM.

@schmidt-sebastian schmidt-sebastian merged commit 458db5f into master Oct 1, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/maketestspass branch October 1, 2019 15:48
@firebase firebase locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants