Skip to content

Update SequenceNumber in LocalStore.applyRemoteEvent #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

Update SequenceNumber in LocalStore.applyRemoteEvent #2233

merged 1 commit into from
Oct 3, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

iOS and Android update the sequence number in LcoalStore.applyRemoteEvent(). This prevents LRU GC for a query that does not explicitly go through releaseQuery.

wilhuff
wilhuff approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that this benefit is only realized during an unclean shutdown or for fire-and-forget listeners. LRU GC considers active queries to be "pinned" and excluded from GC regardless of their sequence numbers.

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Oct 3, 2019
@schmidt-sebastian schmidt-sebastian merged commit 29c0b37 into master Oct 3, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/sequence branch October 10, 2019 22:55
@firebase firebase locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmidt-sebastian @wilhuff