Skip to content

Update Installations types #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2019
Merged

Update Installations types #2246

merged 1 commit into from
Oct 9, 2019

Conversation

mmermerkaya
Copy link
Contributor

Forgot this in #2239.

dwoffinden
dwoffinden approved these changes Oct 8, 2019
View reviewed changes
Copy link

@dwoffinden dwoffinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are there two copies? :/

@mmermerkaya mmermerkaya merged commit 83aacd8 into master Oct 9, 2019
@mmermerkaya mmermerkaya deleted the mmermerkaya-installations-types branch October 9, 2019 16:55
@firebase firebase locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwoffinden dwoffinden dwoffinden approved these changes

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@andirayo andirayo Awaiting requested review from andirayo

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmermerkaya @dwoffinden @Feiyang1