Serialize Timestamps as string (per proto3 JSON format). #2249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this broke our tests. Can you take a look? |
|
It's actually broken since we lost nanosecond precision. I'll revise the PR. |
|
Fixed |
yuchenshi
force-pushed
the
ys/firestore-proto-timestamp
branch
from
0badeff to
caad4e0
Compare
schmidt-sebastian
approved these changes
Oct 10, 2019
schmidt-sebastian
approved these changes
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes using timestamps with the Firestore Emulator. This is similar to #2228, but for timestamps.
Discussion
(Internal tracking ID: 37282237)
Testing
Tested manually against the Firestore Emulator and production Firestore.
API Changes
None.