Skip to content

Include add_payment_info and page_view events #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Include add_payment_info and page_view events #2276

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37e978c
Include add_payment_info and page_view events
cdoe Oct 17, 2019
5f31b77
Include appropriate eventParams
cdoe Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion packages/firebase/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3961,7 +3961,21 @@ declare namespace firebase.analytics {
* ```
*/
app: firebase.app.App;


/**
* Sends analytics event with given `eventParams`. This method
* automatically associates this logged event with this Firebase web
* app instance on this device.
* List of official event parameters can be found in
* {@link https://developers.google.com/gtagjs/reference/event
* the gtag.js reference documentation}.
*/
logEvent(
eventName: 'add_payment_info',
eventParams?: {},
options?: firebase.analytics.AnalyticsCallOptions
): void;

/**
* Sends analytics event with given `eventParams`. This method
* automatically associates this logged event with this Firebase web
Expand Down Expand Up @@ -4076,6 +4090,20 @@ declare namespace firebase.analytics {
},
options?: firebase.analytics.AnalyticsCallOptions
): void;

/**
* Sends analytics event with given `eventParams`. This method
* automatically associates this logged event with this Firebase web
* app instance on this device.
* List of official event parameters can be found in
* {@link https://developers.google.com/gtagjs/reference/event
* the gtag.js reference documentation}.
*/
logEvent(
eventName: 'page_view',
eventParams?: {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For page_view I think it should be:

eventParams: {
        page_title?: string;
        page_location?: string;
        page_path?: string;
        [key: string]: any;
      }

Source: https://developers.google.com/analytics/devguides/collection/gtagjs/pages

options?: firebase.analytics.AnalyticsCallOptions
): void;

/**
* Sends analytics event with given `eventParams`. This method
Expand Down