Fix validation of nested arrays to allow indirect nesting #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change indirectly nested arrays are allowed. We still disallow directly nested arrays. Fixes internal bug b/66253451. Port of firebase/firebase-ios-sdk#377
wilhuff
requested review from
jshcrowthe and
schmidt-sebastian
as code owners
|
This bug is holding us back. When will the fix hit the road? |
|
Post merge it should be soon, but we can't comment on specific timelines, sorry. |
mikelehen
approved these changes
Oct 17, 2017
| const context = new ParseContext( | ||
| this.dataSource, | ||
| this.methodName, | ||
| childPath, | ||
| false, |
There was a problem hiding this comment.
Can you comment the boolean literal?
/*arrayElement=*/ false
| return new ParseContext( | ||
| this.dataSource, | ||
| this.methodName, | ||
| null, |
There was a problem hiding this comment.
Comment literals?
/*path=*/ null,
/*arrayElement=*/ true
|
Josh, can you approve the .gitignore change? |
jshcrowthe
approved these changes
Oct 17, 2017
|
Fixes issue #193 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change indirectly nested arrays are allowed. We still disallow
directly nested arrays.
Fixes internal bug b/66253451.
Port of firebase/firebase-ios-sdk#377