Skip to content

Add an initial CHANGELOG for firestore #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 18, 2017
Merged

Add an initial CHANGELOG for firestore #233

merged 4 commits into from
Oct 18, 2017

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Oct 17, 2017

No description provided.

@wilhuff wilhuff requested a review from jshcrowthe October 17, 2017 23:16
mikelehen
mikelehen suggested changes Oct 17, 2017
View reviewed changes
packages/firestore/CHANGELOG.md Outdated
@@ -0,0 +1,5 @@
# v4.6.0
- [fixed] Fixes validation of nested arrays to allow indirect nesting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a change in 4.5.1 too. You can copy/paste from https://firebase.google.com/support/release-notes/js#4.5.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Done.

jshcrowthe
jshcrowthe suggested changes Oct 17, 2017
View reviewed changes
Copy link
Contributor

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to do package specific changelogs can we do the version listed in packages/firestore/package.json?

@wilhuff
Copy link
Contributor Author

wilhuff commented Oct 18, 2017 •
edited
Loading

Tests are failing due to flakiness, in this case due to the firestore integration tests timing out on ChromeHeadless

firebase-firestore-integration-test: 18 10 2017 01:32:25.664:WARN [HeadlessChrome 0.0.0 (Linux 0.0.0)]: Disconnected (1 times), because no message in 65000 ms.
firebase-firestore-integration-test: HeadlessChrome 0.0.0 (Linux 0.0.0) ERROR
firebase-firestore-integration-test:   Disconnected, because no message in 65000 ms.
firebase-firestore-integration-test: HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 132 of 325 (skipped 8) DISCONNECTED (4 mins 22.439 secs / 36.406 secs)

We need to adjust the permissions in this repository.

Note that no code actually changed here, but this can't be submitted.

@jshcrowthe jshcrowthe merged commit 326a187 into master Oct 18, 2017
@jshcrowthe jshcrowthe deleted the wilhuff/changelog branch October 18, 2017 17:12
@firebase firebase locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

@jshcrowthe jshcrowthe jshcrowthe approved these changes

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees
No one assigned
Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wilhuff @mikelehen @jshcrowthe @google-oss-bot