Fixing named prop "_lat" #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
reviewed
Oct 18, 2017
packages/firebase/webpack.config.js
Outdated
| @@ -40,7 +40,7 @@ const baseConfig = { | |||
| mangle: { | |||
| props: { | |||
| ignore_quoted: true, | |||
| regex: /^_[^_]|[^_]_$/ | |||
| regex: /^_[^_][^lat]|[^_]_$/ | |||
There was a problem hiding this comment.
Can you please comment this? Somebody reading this is going to have no idea why this regex is what it is. And in 2 years we'll have no idea whether we still need "lat" and what might happen if we remove it.
mikelehen
approved these changes
Oct 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a minification error causing some odd issues with auth state persistence.
Fixes #230