Don't use "long" in Proto types #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
approved these changes
Nov 27, 2019
| @@ -363,7 +363,7 @@ export declare namespace firestoreV1ApiClientInterfaces { | |||
| booleanValue?: boolean; | |||
| integerValue?: string; | |||
| doubleValue?: number; | |||
| timestampValue?: string | { seconds: long; nanos: long }; | |||
| timestampValue?: string | { seconds: string; nanos: number }; | |||
There was a problem hiding this comment.
Hrm. I wonder if this should technically be string|number ? I don't think it's required to send seconds as a string, but we do to avoid number overflows.
I don't care strongly though. If it compiles, then it's good enough for now.
There was a problem hiding this comment.
I think you are right, but that breaks our internal type:
// This is a supplement to the generated proto interfaces, which fail to account
// for the fact that a timestamp may be encoded as either a string OR this.
interface TimestampProto {
seconds?: string;
nanos?: number;
}
That's why I just use strings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"long" is not defined and throws a diagnostic error:
Error: TypeScript Diagnostic Error : ../../firebase/firebase-js-sdk/packages/firestore/src/protos/firestore_proto_api.d.ts(366,42): error TS2304: Cannot find name 'long'.