Skip to content

Add @firebase/component to database's dependency #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Dec 6, 2019

No description provided.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feiyang1 Feiyang1 changed the title Add @firebase/component database's dependency Add @firebase/component to database's dependency Dec 6, 2019
@Feiyang1 Feiyang1 changed the base branch from master to release December 6, 2019 18:51
@Feiyang1 Feiyang1 force-pushed the fei-database-dep-fix branch from 1b04290 to 9b050fd Compare December 6, 2019 19:07
@Feiyang1 Feiyang1 merged commit a20ce23 into release Dec 6, 2019
@Feiyang1 Feiyang1 deleted the fei-database-dep-fix branch December 6, 2019 20:13
@hsubox76 hsubox76 added this to the 7.5.2 milestone Dec 12, 2019
@firebase firebase locked and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants