Add minified integration tests to Firestore #2448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
reviewed
Dec 18, 2019
|
#2445 makes them run again (or is supposed to - the PR currently fails to resolve its dependencies in CI as well as locally) |
Feiyang1
approved these changes
Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the tests in integration/firestore to use the "minified" browser build and lets us verify our SDK once we turn on property name mangling.
This is pretty hacky and relies on a complete build of all SDKs, but short of converting our integration/firestore to Rollup, this might be the easiest way. Comments/suggestions more than welcome!