Skip to content

Update code owners for emulators #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

Update code owners for emulators #2494

merged 1 commit into from
Jan 7, 2020

Conversation

avolkovi
Copy link
Contributor

@avolkovi avolkovi commented Jan 7, 2020

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@avolkovi avolkovi requested a review from ryanpbrewster January 7, 2020 00:16
@ryanpbrewster ryanpbrewster merged commit 0adebf4 into master Jan 7, 2020
@ryanpbrewster ryanpbrewster deleted the avolkovi-patch-1 branch January 7, 2020 21:42
@hsubox76 hsubox76 added this to the next milestone Jan 7, 2020
@firebase firebase locked and limited conversation to collaborators Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanpbrewster ryanpbrewster ryanpbrewster approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@avolkovi @ryanpbrewster @hsubox76