Add TS compile check before tests for core-owned packages #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test Typescript compiler,
ts-loaderfor Webpack, doesn't exit if there's a compilation error. If it's a minor error (type mismatch) which doesn't prevent compilation to JavaScript, it will show the error, but create the file, and exit with a 0 code, then run tests. Although these are minor errors, they seem worth catching in the tests.This change fixes a type error in analytics tests and updates test scripts for all JScore-owned packages to try TS compilation before running tests. Will roll out to other packages in a future change.