Remove instanceof IndexedDbRemoteDocumentCache check #2566
Conversation
| * Returns the set of documents that have been updated since the specified read | ||
| * time. | ||
| */ | ||
| // PORTING NOTE: This is only used for multi-tab synchronization. |
There was a problem hiding this comment.
Drive by comment: don't the comments still apply? (i.e. isn't this still only used for multi-tab?)
There was a problem hiding this comment.
The comment is already on the interface declaration.
|
@var-const Do you have cycles for this today? |
| * SnapshotVersion.MIN if not available. | ||
| */ | ||
| // PORTING NOTE: This is only used for multi-tab synchronization. | ||
| getLastReadTime( |
There was a problem hiding this comment.
Question: why is this declaration here, whereas previously getLastDocumentChange wasn't?
There was a problem hiding this comment.
It allows me to use this method in Persistence without checking instanceof IndexedDbRemoteDocumentCache
schmidt-sebastian
changed the title
|
Changed the PR title to "Remove instanceof IndexedDbRemoteDocumentCache check" to be more in line with the intention of the PR. Thanks for the review! |
1 similar comment
|
Changed the PR title to "Remove instanceof IndexedDbRemoteDocumentCache check" to be more in line with the intention of the PR. Thanks for the review! |
Goal: remove
instanceof IndexedDbRemoteDocumentCachecheck in LocalStore to allow me to drop the import.Realized: We don't even use the document result from getLastDocumentChange. So I changed it to only return the read time.