Skip to content

[testing] Fix bug in check for modified files #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2020
Merged

[testing] Fix bug in check for modified files #2568

merged 2 commits into from
Jan 24, 2020

Conversation

hsubox76
Copy link
Contributor

Used a language feature that doesn't exist. Causes check for modified files to always fail. Tested this time to make sure it works.

hiranya911
hiranya911 approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

:)

@hsubox76 hsubox76 merged commit 12f9b9b into master Jan 24, 2020
schmidt-sebastian pushed a commit that referenced this pull request Jan 27, 2020
@hsubox76 @schmidt-sebastian
[testing] Fix bug in check for modified files (#2568)
cead51e
@firebase firebase locked and limited conversation to collaborators Feb 24, 2020
@hsubox76 hsubox76 deleted the ch-testfix2 branch June 18, 2020 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsubox76 @hiranya911