Skip to content

Fix generate_spec_json script. #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2017
Merged

Fix generate_spec_json script. #257

merged 1 commit into from
Oct 23, 2017
+7 −2

Conversation

mikelehen
Copy link
Contributor

  • The tsconfig path was broken after the recent repo refactor.
  • We were accidentally leaving a .ts in the destination json file names.
  • I made it so the destination directory doesn't need to exist in advance.

Fix generate_spec_json script.
966ac86 
* The tsconfig path was broken after the recent repo refactor.
* We were accidentally leaving a .ts in the destination json file names.
* I made it so the destination directory doesn't need to exist in advance.
@mikelehen mikelehen merged commit fba3c06 into master Oct 23, 2017
@mikelehen mikelehen deleted the mikelehen-fix-json-spec-generation branch October 23, 2017 17:11
@firebase firebase locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@wilhuff wilhuff Awaiting requested review from wilhuff

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikelehen @schmidt-sebastian @wilhuff @google-oss-bot