Skip to content

CI test workflow improvements #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 29, 2020
Merged

CI test workflow improvements #2576

merged 10 commits into from
Jan 29, 2020

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jan 27, 2020

Run all tests when files that affect the repo globally are changed, such as top-level dependencies and test/compile/lint config files.

Edit: Also now that some PRs only run partial tests, ensure canary deploy only runs after successful test run. if should ensure it only runs once on each PR merge and not after every full test run (such as the scheduled ones).

@hsubox76 hsubox76 changed the title Set some files that will trigger running all tests CI test workflow improvements Jan 28, 2020
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of nits.

@hiranya911 hiranya911 assigned hsubox76 and unassigned hiranya911 Jan 29, 2020
@hsubox76 hsubox76 merged commit cf18519 into master Jan 29, 2020
@firebase firebase locked and limited conversation to collaborators Feb 29, 2020
@hsubox76 hsubox76 deleted the ch-testfix branch April 3, 2020 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants