Skip to content

Firestore typings fix: Add firestore() to firebase.app.App. #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2017
Merged

Firestore typings fix: Add firestore() to firebase.app.App. #263

merged 1 commit into from
Oct 25, 2017

Conversation

mikelehen
Copy link
Contributor

@tstirrat noticed this was missing.

@mikelehen mikelehen requested a review from jshcrowthe as a code owner October 25, 2017 17:14
jshcrowthe
jshcrowthe approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 nice catch @tstirrat

@jshcrowthe jshcrowthe merged commit 0f888d1 into master Oct 25, 2017
@jshcrowthe jshcrowthe deleted the mikelehen-add-firestore-to-app branch October 25, 2017 20:05
@firebase firebase locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jshcrowthe jshcrowthe jshcrowthe approved these changes

Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikelehen @jshcrowthe @google-oss-bot