Fixing Typings for RTDB #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshcrowthe
requested review from
mikelehen and
schmidt-sebastian
as code owners
|
This looks good on the condition that we revisit our public typings before we release a v1 version of our modules to make sure that our publicly exported typings actually match our publicly supported (approved, publicly documented / supported) API surface area. I don't want to accidentally leak implementation details / unapproved APIs into our typings. |
mikelehen
approved these changes
Oct 25, 2017
|
SGTM, thanks @hiranya911 and @mikelehen! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Admin SDK is trying to consume the
@firebase/databasepackage as a standalone. This fixes some of the typings to better support that.