Skip to content

Fix prettier precommit script to not error if there are only deleted files #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2020
Merged

Fix prettier precommit script to not error if there are only deleted files #2641

merged 3 commits into from
Feb 18, 2020

Conversation

hsubox76
Copy link
Contributor

git diff step now filters out deleted files.

@hsubox76 hsubox76 merged commit eb4fe34 into master Feb 18, 2020
@hsubox76 hsubox76 deleted the ch-prettierfix branch February 26, 2020 20:24
@firebase firebase locked and limited conversation to collaborators Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsubox76 @Feiyang1