Fix VS Code launch.json to look for mocha/karma in the right location #2642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebrianchen
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
schmidt-sebastian
suggested changes
Feb 18, 2020
There was a problem hiding this comment.
This might break other consumers of the Firestore tests.
It might be better to add a dev dependency on mocha here:
Be sure to use the same version that is used in other parts of the SDK. If you add this dev dependency, then Mocha will also be available in packages/firestore/node_modules/.bin/_mocha
thebrianchen
force-pushed
the
bc/vscode
branch
from
c47d697 to
9fb7550
Compare
schmidt-sebastian
approved these changes
Feb 20, 2020
hsubox76
approved these changes
Feb 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those of us who haven't hopped on the IntelliJ train yet.
+cc @wu-hui