Skip to content

Remove backgroundChannelTest and testUrl from WebChannelOptions #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Remove backgroundChannelTest and testUrl from WebChannelOptions #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/firestore/src/platform_browser/webchannel_connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,6 @@ export class WebChannelConnection implements Connection {
];
const webchannelTransport = createWebChannelTransport();
const request: WebChannelOptions = {
// Background channel test avoids the initial two test calls and decreases
// initial cold start time.
// TODO(dimond): wenboz@ mentioned this might affect use with proxies and
// we should monitor closely for any reports.
backgroundChannelTest: true,
// Required for backend stickiness, routing behavior is based on this
// parameter.
httpSessionIdParam: 'gsessionid',
Expand Down
4 changes: 0 additions & 4 deletions packages/webchannel-wrapper/externs/overrides.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ goog.net.WebChannel.Options.concurrentRequestLimit;
/** @type {boolean|undefined} */
goog.net.WebChannel.Options.supportsCrossDomainXhr;

/** @type {string|undefined} */
goog.net.WebChannel.Options.testUrl;

/** @type {boolean|undefined} */
goog.net.WebChannel.Options.sendRawJson;

Expand All @@ -57,7 +54,6 @@ goog.net.WebChannel.Options.httpSessionIdParam;
/** @type {string|undefined} */
goog.net.WebChannel.Options.httpHeadersOverwriteParam;

/** @type {boolean|undefined} */
goog.net.WebChannel.Options.backgroundChannelTest;

/** @type {boolean|undefined} */
Expand Down
2 changes: 0 additions & 2 deletions packages/webchannel-wrapper/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,9 @@ export interface WebChannelOptions {
clientProtocolHeaderRequired?: boolean;
concurrentRequestLimit?: number;
supportsCrossDomainXhr?: boolean;
testUrl?: string;
sendRawJson?: boolean;
httpSessionIdParam?: string;
httpHeadersOverwriteParam?: string;
backgroundChannelTest?: boolean;
forceLongPolling?: boolean;
fastHandshake?: boolean;
disableRedac?: boolean;
Expand Down