Use explicit String constants for OnlineState #2688
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Feiyang1 noticed in a sample app that multitab is not able to parse OnlineStates since the constants are rewritten to __PRIVATE_OnlineState:
This PR removes the enum usage for OnlineState, to make sure that the constant names are not mangled.
Multi-Tab uses the same concept for its other "enums":
firebase-js-sdk/packages/firestore/src/local/shared_client_state.ts
Line 209 in bb1f4de
As a guide, the size impact of this PR: