Update Package Dependencies #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshcrowthe
requested review from
gauntface,
mikelehen,
schmidt-sebastian,
sphippen and
wilhuff
as code owners
wilhuff
reviewed
Oct 26, 2017
| "chai": "^4.1.1", | ||
| "karma": "^1.7.0", | ||
| "karma-chrome-launcher": "^2.2.0", | ||
| "karma-mocha": "^1.3.0", | ||
| "karma-sauce-launcher": "^1.2.0", | ||
| "karma-spec-reporter": "0.0.31", | ||
| "mkdirp": "^0.5.1", | ||
| "mocha": "^3.5.0" | ||
| "mocha": "^4.0.1" |
There was a problem hiding this comment.
mocha 4 introduced a breaking change in that it will no longer force the test process to exit. Should we also configure our test runner to exit by passing --exit?
There was a problem hiding this comment.
Ahhh thank you sir! I was pulling down Travis to debug this very issue. I will refactor to pass --exit see if that alleviates the CI Issues.
|
@wilhuff thanks for your help w/ this. All tests are passing with the |
gauntface
approved these changes
Oct 27, 2017
sphippen
approved these changes
Oct 30, 2017
schmidt-sebastian
approved these changes
Oct 30, 2017
schmidt-sebastian
pushed a commit
that referenced
this pull request
Nov 3, 2017
* Update dependencies throughout application * Adjust to mocha 4 breaking runner issues * Updating webpack dep
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured I'd close the previous PR as it had some unnecessary commit noise. This should be a little cleaner.