Make Serializer tests work in browser, remove test duplication #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
reviewed
Mar 18, 2020
| @@ -0,0 +1,40 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2017 Google Inc. | |||
| * Verifies full round-trip of JSON protos through ProtobufJs. | ||
| */ | ||
| export function verifyProtobufJsRoundTrip(jsonValue: api.Value): void { | ||
| const protobufJsEncocdedProto = ValueMessage.fromObject(jsonValue); |
There was a problem hiding this comment.
Typos in Encocded and Decocded.
|
|
||
| let verifyProtobufJsRoundTrip: (jsonValue: api.Value) => void = () => {}; | ||
|
|
||
| if (isNode()) { |
There was a problem hiding this comment.
It seems like you could just inline the definition of verifyProtobufJsRoundTrip here. It doesn't seem like it would be useful in any other context because it hard codes the use of ValueMessage.
There was a problem hiding this comment.
I put in a separate file so we could import ProtobufJs and its types using "import" instead of "require". This gives us type safety. If I included it here, I would have to rely on the d.t.s files for these dependencies to use the types safely, without importing the actual sources (an import of ProtobufJs here would break the build for the browser tests)..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some of the duplicated serialization tests in FieldValue and changes the tests in serializer to run in the browser. My goal was to keep the test coverage the same, so on Node it still roundtrips through ProtobufJs.