Support storage.googleapis.com in refFromUrl

[schmidt-sebastian]

This modifies refFromUrl to accept URLs generated by Cloud Storage.

Tested that this supports URLs from the Cloud Console as well as the format specified here:

https://cloud.google.com/storage/docs/access-control/signed-urls

Fixes #2625

[fredzqm]

OOC, will this generate the same result?
https://storage.cloud.google.com/mybucket/path%20with%20space%2Fimage.png

Maybe add a test.

[schmidt-sebastian]

I added a test.

[fredzqm]

What's special about #? Trying to understand the difference between firebaseStoragePath and cloudStoragePath.

[schmidt-sebastian]

We should probably exclude # in both cases, even though I don't see GCS creating URLs that provide anchors. I updated the cloudStoragePath.

I am not sure why we are using an extra .* in firebaseStoragePath, but I'd rather leave it the way it was as I can see neither harm nor benefit.

[schmidt-sebastian]

@Feiyang1 for approval. Thanks.

[google-oss-bot]

Binary Size Report

Affected SDKs

SDK	Type	Base (a85f81d)	Head (669d900)	Diff
@firebase/logger	module	?	4778.00	? (?)
	esm2017	?	3223.00	? (?)
	main	?	5087.00	? (?)
@firebase/storage	module	?	62706.00	? (?)
	esm2017	?	56574.00	? (?)
	main	?	62912.00	? (?)
@firebase/util	module	?	18551.00	? (?)
	browser	?	19454.00	? (?)
	esm2017	?	17369.00	? (?)
	main	?	19481.00	? (?)
@firebase/app	react-native	?	9862.00	? (?)
	lite-esm2017	?	7748.00	? (?)
	module	?	11011.00	? (?)
	browser	?	11108.00	? (?)
	esm2017	?	9461.00	? (?)
	main	?	10105.00	? (?)
	lite	?	9102.00	? (?)
@firebase/firestore	module	?	269748.00	? (?)
	browser	?	272957.00	? (?)
	esm2017	?	269748.00	? (?)
	main	?	490305.00	? (?)
@firebase/installations	module	?	21544.00	? (?)
	esm2017	?	16530.00	? (?)
	main	?	21995.00	? (?)
@firebase/functions	module	?	8994.00	? (?)
	browser	?	9174.00	? (?)
	esm2017	?	7010.00	? (?)
	main	?	9209.00	? (?)
@firebase/webchannel-wrapper	module	?	41226.00	? (?)
	main	?	40383.00	? (?)
@firebase/performance	module	?	24914.00	? (?)
	browser	?	25158.00	? (?)
	esm2017	?	23188.00	? (?)
	main	?	25158.00	? (?)
firebase	firebase-installations.js	?	19436.00	? (?)
	firebase-storage.js	?	41411.00	? (?)
	firebase-messaging.js	?	39431.00	? (?)
	firebase.js	?	847343.00	? (?)
	firebase-auth.js	?	175057.00	? (?)
	firebase-analytics.js	?	26780.00	? (?)
	firebase-performance-standalone.js	?	46946.00	? (?)
	firebase-remote-config.js	?	37217.00	? (?)
	firebase-performance.js	?	37211.00	? (?)
	firebase-app.js	?	20008.00	? (?)
	firebase-firestore.js	?	313937.00	? (?)
	firebase-database.js	?	185548.00	? (?)
	firebase-performance-standalone.es2017.js	?	70398.00	? (?)
	firebase-functions.js	?	9642.00	? (?)
@firebase/analytics	module	?	9371.00	? (?)
	esm2017	?	8682.00	? (?)
	main	?	9689.00	? (?)
@firebase/auth	module	?	177089.00	? (?)
	main	?	177099.00	? (?)
@firebase/remote-config	module	?	22720.00	? (?)
	browser	?	23103.00	? (?)
	esm2017	?	17705.00	? (?)
	main	?	23103.00	? (?)
@firebase/testing	main	?	6598.00	? (?)
@firebase/messaging	module	?	30549.00	? (?)
	esm2017	?	22806.00	? (?)
	main	?	31006.00	? (?)
@firebase/database	module	?	264057.00	? (?)
	browser	?	265575.00	? (?)
	esm2017	?	232641.00	? (?)
	main	?	266339.00	? (?)
@firebase/component	module	?	5046.00	? (?)
	browser	?	5164.00	? (?)
	esm2017	?	3898.00	? (?)
	main	?	5164.00	? (?)
@firebase/polyfill	module	?	666.00	? (?)
	main	?	733.00	? (?)

Metric Unit: byte

Test Logs

• https://github.com/firebase/firebase-js-sdk/actions/runs/63997839