Skip to content

Remove base64 encoding of resume tokens in spec tests. #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2020
Merged

Remove base64 encoding of resume tokens in spec tests. #2760

merged 2 commits into from
Mar 18, 2020

Conversation

dconeybe
Copy link
Contributor

Fixes: #2759

@dconeybe dconeybe requested a review from thebrianchen March 18, 2020 14:52
@dconeybe dconeybe self-assigned this Mar 18, 2020
thebrianchen
thebrianchen approved these changes Mar 18, 2020
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@dconeybe dconeybe merged commit c8bebeb into master Mar 18, 2020
@dconeybe dconeybe deleted the dconeybe/b64spec branch March 18, 2020 16:20
@firebase firebase locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@dconeybe dconeybe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spec tests should not use base64-encoded resume tokens
2 participants
@dconeybe @thebrianchen