feat(sw-controller): compare host instead of href for getWindowClient #2772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @mmermerkaya for review (sorry if disturbing, I don't know who to ping for a review and can't request a review 🤷♂) |
|
Pinging @schmidt-sebastian for review or help to know who to ping or how to ask a review, sorry for the disturbance ! |
|
I will find someone to review on Monday. |
zwu52
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Hi Nicolas,
Thanks for identifying the issue and creating the PR. I think it is reasonable to have a fuzzier match for recognizing pages with the same origin as the same page. So that FCM opens minimal number of windows for users and be respectful. I will create a release note for this. cheers 🍺
|
@Feiyang1 Hey Feiyang, do you mind taking a look and grant owner's approval for this? 😃 |
Feiyang1
approved these changes
Apr 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks,
Instead of comparing the href (cause the user can be in a other page), we compare the host and take the first page that has the same host
Fix: #390