Skip to content

include firestore memory builds and sub modules in the size report #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2020
Merged

include firestore memory builds and sub modules in the size report #2798

merged 3 commits into from
Mar 26, 2020

Conversation

Feiyang1
Copy link
Member

No description provided.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

SDKTypeBase (0d0bdc1)Head (f1ae43e)Diff
@firebase/firestore/memorymodule?225636.00? (?)
browser?228627.00? (?)
esm2017?172326.00? (?)
main?403905.00? (?)
firebasefirebase-firestore.memory.js?270773.00? (?)
Metric Unit: byte

Test Logs

@schmidt-sebastian schmidt-sebastian removed their assignment Mar 25, 2020
yifanyang
yifanyang approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@yifanyang yifanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned yifanyang Mar 25, 2020
@Feiyang1 Feiyang1 merged commit 17e3e61 into master Mar 26, 2020
@Feiyang1 Feiyang1 deleted the fei-sr-mo branch March 26, 2020 19:05
@firebase firebase locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yifanyang yifanyang yifanyang approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Feiyang1 @google-oss-bot @yifanyang @hsubox76 @schmidt-sebastian