Skip to content

Fixing dangling comma on package.json #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fixing dangling comma on package.json #2811

merged 1 commit into from
Mar 27, 2020

Conversation

bernardodomingues-hotmart
Copy link
Contributor

The original file was an invalid JSON, which could potentially break builds that would parse JSON files. Fixes #2810

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

The original file was an invalid JSON, which could potentially break builds that would parse JSON files.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Feiyang1
Copy link
Member

@bernardodomingues-hotmart Thanks for the fix. Can you please sign the CLA?

@bernardodomingues-hotmart
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@bernardodomingues-hotmart
Copy link
Contributor Author

@Feiyang1 There you go

@Feiyang1 Feiyang1 merged commit f1ddd70 into firebase:master Mar 27, 2020
Feiyang1 pushed a commit that referenced this pull request Mar 27, 2020
The original file was an invalid JSON, which could potentially break builds that would parse JSON files.
@firebase firebase locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid JSON @ firebase/firestore/memory/package.json
3 participants