Tree-Shake ES5 classes #2829
Closed
Tree-Shake ES5 classes #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
Binary Size ReportAffected SDKs
Test Logs |
schmidt-sebastian
force-pushed
the
mrschmidt/betterbuilds
branch
from
c2808cb to
bd2ac17
Compare
schmidt-sebastian
changed the title
schmidt-sebastian
force-pushed
the
mrschmidt/betterbuilds
branch
from
bd2ac17 to
152e544
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/betterbuilds
branch
from
152e544 to
0044c22
Compare
|
Nice. Can you please check if source maps work correctly? I have used this workaround when doing size analysis. The size analysis tool told me the source maps are invalid where the number of lines mismatch, so I just switched to use es2017 builds for analysis. |
|
Yeah, the source maps are not working... Looking into it. |
schmidt-sebastian
force-pushed
the
mrschmidt/betterbuilds
branch
from
175a2e6 to
a4781c8
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup doesn't tree-shake ES5 classes since it cannot detect that they are side-effect free. The recommended way to solve this is to not use Typescript for the ES5 conversion, but Babel. Unfortunately, Typescript's ES5 is much smaller than Babels.
Luckily, the Internet answers all questions:
Typescript emits "@Class" comment when a class is side-effect free:
microsoft/TypeScript#13721
This can be rewritten to PURE as show here:
rollup/rollup#2807 (comment)