Skip to content

@firebase/app modularization #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 31, 2020
Merged

@firebase/app modularization #2836

merged 23 commits into from
Mar 31, 2020

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Mar 31, 2020 •
edited
Loading

Replace #2709 with new folder structure

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 31, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (50de3fb)Head (64808bf)Diff
@firebase/firestore/memorybrowser224500.00224475.00-25.00 (-0.01%)
module221680.00221655.00-25.00 (-0.01%)
esm2017170334.00170304.00-30.00 (-0.02%)
main397701.00397404.00-297.00 (-0.07%)
@firebase/firestorebrowser271073.00271055.00-18.00 (-0.01%)
module267852.00267834.00-18.00 (-0.01%)
esm2017216152.00216141.00-11.00 (-0.01%)
main488427.00488418.00-9.00 (-0.00%)
firebasefirebase.js846912.00846872.00-40.00 (-0.00%)
firebase-firestore.memory.js266794.00266750.00-44.00 (-0.02%)
firebase-firestore.js312035.00311995.00-40.00 (-0.01%)
Metric Unit: byte

Test Logs

hsubox76
hsubox76 approved these changes Mar 31, 2020
View reviewed changes
@Feiyang1 Feiyang1 merged commit 60116ca into master Mar 31, 2020
@Feiyang1 Feiyang1 deleted the fei-app-next-2 branch March 31, 2020 23:00
@firebase firebase locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feiyang1 @google-oss-bot @hsubox76