Fix Saucelabs tests in analytics and functions #2845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs |
Feiyang1
reviewed
Apr 1, 2020
packages/analytics/index.test.ts
Outdated
| @@ -88,7 +88,8 @@ describe('FirebaseAnalytics instance tests', () => { | |||
| currency: 'USD' | |||
| }); | |||
| // Clear event stack of async FID call. | |||
| await fidDeferred.promise; | |||
| // For IE: Need to wrap it in another function as FID fetch is wrapped in initializeGAId. | |||
| await (() => fidDeferred.promise); | |||
There was a problem hiding this comment.
Does it really work? Do you mean to execute the function, (async () => fidDeferred.promise)()?
There was a problem hiding this comment.
It did work but I don't know why, which seems bad. I changed it to something more readable but doesn't follow the logic as much. For some reason, only IE executes the expect assertions immediately after the mock FID promise resolves instead of executing the gtag config statements which should be first in line.
I also fixed another issue on the last test in index.test.ts where the config calls were resolving after the test was disposed of, which again seems to be IE only.
Feiyang1
approved these changes
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some failing IE tests in analytics and functions.
Also fixed error in workflow file so that cross-browser workflow will run again.