Skip to content

Actually fix resume token debugging in spec tests #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2020
Merged

Actually fix resume token debugging in spec tests #2877

merged 1 commit into from
Apr 6, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Attempt number three (I think).

@dconeybe
Copy link
Contributor

dconeybe commented Apr 6, 2020

LGTM

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

SDKTypeBase (5a63738)Head (86c3479)Diff
Metric Unit: byte

Test Logs

wilhuff
wilhuff approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Apr 6, 2020
@schmidt-sebastian schmidt-sebastian merged commit 027a783 into master Apr 6, 2020
@firebase firebase locked and limited conversation to collaborators May 7, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixresumetoken branch July 9, 2020 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

@dconeybe dconeybe Awaiting requested review from dconeybe

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @dconeybe @google-oss-bot @wilhuff