Add AdditionalUserInfo class to auth-exp #2979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottcrossen
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
Binary Size ReportAffected SDKs
Test Logs
|
avolkovi
reviewed
Apr 24, 2020
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
avolkovi
reviewed
Apr 24, 2020
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
avolkovi
reviewed
Apr 24, 2020
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
avolkovi
reviewed
Apr 24, 2020
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
avolkovi
reviewed
Apr 24, 2020
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
avolkovi
reviewed
Apr 24, 2020
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
avolkovi
reviewed
Apr 24, 2020
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
avolkovi
reviewed
Apr 24, 2020
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
avolkovi
reviewed
Apr 24, 2020
avolkovi
reviewed
Apr 24, 2020
avolkovi
reviewed
Apr 24, 2020
avolkovi
reviewed
Apr 24, 2020
sam-gc
reviewed
Apr 24, 2020
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
scottcrossen
force-pushed
the
slc/additionaluserinfo
branch
from
48a27b2 to
fa973c9
Compare
scottcrossen
force-pushed
the
slc/additionaluserinfo
branch
2 times, most recently
from
fd8bd0c to
b5b8917
Compare
avolkovi
reviewed
May 7, 2020
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
avolkovi
reviewed
May 7, 2020
avolkovi
reviewed
May 7, 2020
avolkovi
reviewed
May 7, 2020
scottcrossen
force-pushed
the
slc/additionaluserinfo
branch
4 times, most recently
from
c60404f to
98010cb
Compare
avolkovi
reviewed
Jun 17, 2020
| export interface AdditionalUserInfo { | ||
| readonly isNewUser: boolean; | ||
| readonly profile?: UserProfile; | ||
| readonly providerId: ProviderId | null; |
There was a problem hiding this comment.
providerId can't be null https://firebase.google.com/docs/reference/js/firebase.auth#additionaluserinfo
There was a problem hiding this comment.
Well that just isn't true:
There was a problem hiding this comment.
huh, i wonder if our docs need to be updated then
| */ | ||
| export interface AdditionalUserInfo { | ||
| readonly isNewUser: boolean; | ||
| readonly profile?: UserProfile; |
There was a problem hiding this comment.
profile should be UserProfile | null, it's not optional https://firebase.google.com/docs/reference/js/firebase.auth#additionaluserinfo
There was a problem hiding this comment.
The docs are wrong on this as well. It's never set for the base info:
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
packages-exp/auth-exp/src/core/user/additional_user_info.test.ts
Outdated
Show resolved
Hide resolved
avolkovi
reviewed
Jun 17, 2020
sam-gc
reviewed
Jun 17, 2020
avolkovi
approved these changes
Jun 17, 2020
* Add conditional delays to auth-next * [AUTOMATED]: Prettier Code Styling * Use typescript asserts keyword for typesafe assertions * [AUTOMATED]: Prettier Code Styling * Rebase conflicts & PR feedback * More PR Feedback * Strip debug asserts from prod builds * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: API Reports * Fix logic in assertion * Revert merge artifacts * PR Feedback
Added React Native persistence class
scottcrossen
force-pushed
the
slc/additionaluserinfo
branch
from
8d3cce3 to
3f74da0
Compare
sam-gc
reviewed
Jun 23, 2020
| */ | ||
| export function _fromIdTokenResponse( | ||
| idTokenResponse: IdTokenResponse, | ||
| ): AdditionalUserInfo | null { |
There was a problem hiding this comment.
I just raised a big PR to make UserCredential accept generics properly. Not for this PR but eventually we'll probably want to make this function generic as well.
See for example: https://github.com/firebase/firebase-js-sdk/pull/3266/files#diff-4e1f7cb1a27ae1754eb03b583f5607ccL389
sam-gc
approved these changes
Jun 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sent with my hg client