Skip to content

Remove static references to API types #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2020
Merged

Remove static references to API types #3023

merged 2 commits into from
May 6, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

The pattern in api/database.ts breaks tree-shaking since it instatiates static references to all public API types. I moved this code to platform/config.ts which is used to register the non Tree-Shakeable API

@schmidt-sebastian
Remove static references to API types
fc6930f 
The pattern in api/database.ts breaks tree-shaking since it instatiates static references to all public API types. I moved this code to platform/config.ts which is used to register the non Tree-Shakeable API
@schmidt-sebastian schmidt-sebastian requested a review from dconeybe May 5, 2020 18:50
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (da3582b) Head (43c3cc5) Diff
    browser 247 kB 247 kB -35 B (-0.0%)
    esm2017 193 kB 193 kB -37 B (-0.0%)
    main 488 kB 488 kB -49 B (-0.0%)
    module 245 kB 245 kB -35 B (-0.0%)

  • @firebase/firestore/memory

    Type Base (da3582b) Head (43c3cc5) Diff
    browser 188 kB 188 kB -35 B (-0.0%)
    esm2017 148 kB 148 kB -37 B (-0.0%)
    main 365 kB 365 kB -49 B (-0.0%)
    module 187 kB 187 kB -35 B (-0.0%)

  • firebase

    Type Base (da3582b) Head (43c3cc5) Diff
    firebase-firestore.js 286 kB 286 kB -35 B (-0.0%)
    firebase-firestore.memory.js 229 kB 228 kB -35 B (-0.0%)
    firebase.js 820 kB 820 kB -35 B (-0.0%)

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit e67affb into master May 6, 2020
@firebase firebase locked and limited conversation to collaborators Jun 6, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/publicwrappers branch November 9, 2020 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @dconeybe