Skip to content

Remove unused remoteDocumentKeys() #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented May 7, 2020

This is not used and hence we don't need to add recovery logic.

Addresses #2755

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (f9c6dde) Head (a514a35) Diff
    browser 249 kB 249 kB -148 B (-0.1%)
    esm2017 194 kB 194 kB -99 B (-0.1%)
    main 490 kB 490 kB -232 B (-0.0%)
    module 247 kB 247 kB -148 B (-0.1%)
  • @firebase/firestore/memory

    Type Base (f9c6dde) Head (a514a35) Diff
    browser 190 kB 190 kB -148 B (-0.1%)
    esm2017 148 kB 148 kB -99 B (-0.1%)
    main 367 kB 367 kB -232 B (-0.1%)
    module 188 kB 188 kB -148 B (-0.1%)
  • firebase

    Type Base (f9c6dde) Head (a514a35) Diff
    firebase-firestore.js 288 kB 288 kB -147 B (-0.1%)
    firebase-firestore.memory.js 230 kB 230 kB -147 B (-0.1%)
    firebase.js 822 kB 821 kB -147 B (-0.0%)

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit f30de15 into master May 7, 2020
@firebase firebase locked and limited conversation to collaborators Jun 7, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/removeunusedtrans branch November 9, 2020 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants