Transition to primary only if IndexedDB ops succeed #3049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs
|
rafikhan
approved these changes
May 13, 2020
| @@ -1032,9 +1032,6 @@ export class MultiTabSyncEngine extends SyncEngine | |||
|
|
|||
| async applyPrimaryState(isPrimary: boolean): Promise<void> { | |||
| if (isPrimary === true && this.isPrimary !== true) { | |||
| this.isPrimary = true; | |||
There was a problem hiding this comment.
I notice that sync_engine.ts uses a mixture of reading from this.isPrimary and this.isPrimaryClient. Shouldn't all reads be consolidated to the latter? If so, we should fix this in a separate PR.
There was a problem hiding this comment.
this.isPrimaryClient is the getter in the API. this.isPrimary is the underlying member variable. A more common pattern is to use this.isPrimary and this._isPrimary. I will update this is in a follow-up.
Comment on lines
+1046
to
+1047
| this.isPrimary = true; | ||
| await this.remoteStore.applyPrimaryState(true); |
There was a problem hiding this comment.
I want to verify something. These lines of code were moved down b/c the bit should only be set if a prior IndexDB operation succeeded correct?
There was a problem hiding this comment.
Yes, exactly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Don't change local state before all IndexedDB transactions succeed.
Addresses #2755