Skip to content

Clean up isPrimary #3058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

Clean up isPrimary #3058

merged 1 commit into from
May 13, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented May 13, 2020 •
edited
Loading

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 13, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (3960fda) Head (6da84bb) Diff
    browser 249 kB 249 kB -63 B (-0.0%)
    esm2017 194 kB 194 kB -63 B (-0.0%)
    main 490 kB 490 kB +63 B (+0.0%)
    module 247 kB 247 kB -63 B (-0.0%)

  • firebase

    Type Base (3960fda) Head (6da84bb) Diff
    firebase-firestore.js 288 kB 288 kB -63 B (-0.0%)
    firebase.js 821 kB 821 kB -63 B (-0.0%)

Test Logs

rafikhan
rafikhan approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@rafikhan rafikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian schmidt-sebastian merged commit 20a094f into master May 13, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/isprimary branch May 13, 2020 22:47
@firebase firebase locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rafikhan rafikhan rafikhan approved these changes

Assignees

@rafikhan rafikhan

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @rafikhan