Skip to content

Use gcEnabled instead of durable persistence #3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This runs the Memory tests with LRU persistence instead of not running them at all.

Diff without whitespace: https://github.com/firebase/firebase-js-sdk/compare/mrschmidt/gcenabled?expand=1&w=1

This runs the Memory tests with LRU persistence instead of not running them at all
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (0804217) and head commit (ed7244a).

Test Logs

Copy link
Contributor

@var-const var-const left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the link to diff with no whitespace, very useful.

@schmidt-sebastian schmidt-sebastian merged commit f3f1b17 into master May 14, 2020
@firebase firebase locked and limited conversation to collaborators Jun 14, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/gcenabled branch November 9, 2020 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants