Ignore failures for notifyLocalViewChanges #3062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code to ignore failures during
notifyLocalViewChanges
. This should only affect LRU GC and only mean that the documents get GCed earlier.If we have to add recovery logic we probably need to buffer these changes and apply them via
enqueueRetryable
before running LRU GC. That's why I am hoping that we don't need to.Disclaimer: I am not sure if this is actually correct, but I hope it is.
Addresses #2755