Skip to content

Ignore failures for notifyLocalViewChanges #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This adds code to ignore failures during notifyLocalViewChanges. This should only affect LRU GC and only mean that the documents get GCed earlier.

If we have to add recovery logic we probably need to buffer these changes and apply them via enqueueRetryable before running LRU GC. That's why I am hoping that we don't need to.

Disclaimer: I am not sure if this is actually correct, but I hope it is.

Addresses #2755

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/notifylocalviewchanges branch from 19dae50 to 7f4ac04 Compare May 14, 2020 02:06
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/notifylocalviewchanges branch from 7f4ac04 to 6924082 Compare May 14, 2020 02:07
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 14, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (f3f1b17) Head (9859d12) Diff
    browser 249 kB 250 kB +315 B (+0.1%)
    esm2017 194 kB 194 kB +111 B (+0.1%)
    main 490 kB 490 kB +409 B (+0.1%)
    module 247 kB 247 kB +293 B (+0.1%)
  • @firebase/firestore/memory

    Type Base (f3f1b17) Head (9859d12) Diff
    browser 190 kB 190 kB +315 B (+0.2%)
    esm2017 148 kB 148 kB +111 B (+0.1%)
    main 366 kB 367 kB +407 B (+0.1%)
    module 188 kB 188 kB +293 B (+0.2%)
  • firebase

    Type Base (f3f1b17) Head (9859d12) Diff
    firebase-firestore.js 288 kB 288 kB +291 B (+0.1%)
    firebase-firestore.memory.js 230 kB 230 kB +291 B (+0.1%)
    firebase.js 821 kB 822 kB +293 B (+0.0%)

Test Logs

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff May 14, 2020
@schmidt-sebastian schmidt-sebastian merged commit 759b877 into master May 14, 2020
@firebase firebase locked and limited conversation to collaborators Jun 14, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/notifylocalviewchanges branch July 9, 2020 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants