user.delete() implementation #3072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKsNo changes between base commit (b278cea) and head commit (542a5cd). Test Logs
|
avolkovi
reviewed
May 15, 2020
avolkovi
reviewed
May 15, 2020
| const user = new UserImpl({ uid: 'uid', auth, stsTokenManager }); | ||
| expect(() => user.delete()).to.throw(); | ||
| const endpoint = mockEndpoint(Endpoint.DELETE_ACCOUNT, {}); | ||
| const signOut = sinon.stub(auth, 'signOut'); |
There was a problem hiding this comment.
is it possible to test side effects instead of mocking this out?
There was a problem hiding this comment.
Will do this once #2963 merges
avolkovi
reviewed
May 15, 2020
avolkovi
approved these changes
May 15, 2020
sam-gc
force-pushed
the
samgho/auth-delete
branch
from
86c1b2f to
2973aea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.