Enable tests for query rejection. #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKsNo changes between base commit (1325b58) and head commit (0004e8f). Test Logs
|
schmidt-sebastian
approved these changes
May 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for queries where the promise was rejected were disabled because there was not a known way to create a query that was accepted by the client but rejected by the server. Recently, I discovered how to make just such a query: use a collection that is a sub-collection of a document with an invalid name. I have re-enabled these tests using this strategy. Thanks for @schmidt-sebastian for bringing these tests to my attention. (Google internal ticket for this issue: b/156772969).