Fix Saucelabs tests for Firestore unit tests except IE #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs
|
schmidt-sebastian
approved these changes
May 21, 2020
| @@ -143,7 +143,8 @@ describe('AsyncQueue', () => { | |||
| const doStep = (n: number): Promise<number> => | |||
| defer(() => completedSteps.push(n)); | |||
| queue.enqueueAndForget(() => doStep(1)); | |||
| const last = queue.enqueueAfterDelay(timerId1, 5, () => doStep(4)); | |||
| // Flaky on Safari, increasing delay to 1000ms to try to increase reliability. | |||
| const last = queue.enqueueAfterDelay(timerId1, 1000, () => doStep(4)); | |||
There was a problem hiding this comment.
This is too long - we cannot wait a full second for a single test. Can we skip this test in Safari?
There was a problem hiding this comment.
Sure, adding a check.
hsubox76
force-pushed
the
ch-firestore-sl2
branch
from
6d6cb21 to
a288e8c
Compare
hsubox76
commented
May 21, 2020
| @@ -272,11 +273,11 @@ export class TestPlatform implements Platform { | |||
| } | |||
| } | |||
|
|
|||
| /** Returns true if we are running under Node. */ | |||
| export function isNode(): boolean { | |||
There was a problem hiding this comment.
Seems like this wasn't being used anywhere, and there's a better version in @firebase/util so I hope it's okay to remove?
There was a problem hiding this comment.
@wu-hui might have just started using this. He would probably be delighted to switch to the better version :)
Feiyang1
reviewed
May 27, 2020
| @@ -137,7 +138,9 @@ describe('AsyncQueue', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('can schedule ops in the future', async () => { | |||
| // Flaky on Safari. | |||
There was a problem hiding this comment.
Do we know why it is flaky on Safari?
There was a problem hiding this comment.
I haven't been able to find any reason. The test relies on two setTimeouts at 1ms and 5ms happening in the correct order, and sometimes Safari doesn't seem to get the order right. I can't find any known bug or issue that might cause that.
Feiyang1
approved these changes
May 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 1 error in Firefox + Safari and 2 errors in Safari only.
IE is excluded, to be fixed in a future PR, because:
TODO: Next step is to try to run
integration/firestoretests instead of integration tests inpackage/firestore. It is almost ready to run, but has 1 error common across all browsers, 1 exclusive to Firefox, and 12/13 in IE (memory/persistence).