Add Firestore Lite API #3100
Merged
Add Firestore Lite API #3100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/liteapi
branch
from
4da7b48 to
7bac0b4
Compare
Binary Size ReportAffected SDKsNo changes between base commit (babdcfd) and head commit (30ff10f). Test Logs
|
rafikhan
reviewed
May 21, 2020
There was a problem hiding this comment.
Every product has their own typings file (in a separate package). See https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore-types/index.d.ts
I plan to move the typings to firestore-types once development is mostly done as this complicates API changes.
We use one single file for all types that make up an SDK. Thanks for checking!
|
@rafikhan It sounds like you are satisfied with this. If so, can you approve? I can then start on some follow up work. Thanks! |
|
LGTM |
rafikhan
approved these changes
May 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the API for the Lite SDK as approved in go/firestore-next