Add getDoc() #3133
Merged
Add getDoc() #3133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irebase-js-sdk into mrschmidt/initializefirestore
This will be tested when getDoc() is added.
|
|
||
| // Kick off initializing the datastore but don't actually wait for it. | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| PlatformSupport.getPlatform() |
There was a problem hiding this comment.
This code is inspired by similar code in the main Firestore class.
| return this._initializationDone.promise; | ||
| } | ||
|
|
||
| private _makeDatabaseInfo(): DatabaseInfo { |
There was a problem hiding this comment.
|
|
||
| /* eslint-disable no-restricted-globals */ | ||
|
|
||
| /** |
There was a problem hiding this comment.
Moved this code as importing this entire class breaks the Lite compile with typings conflicts.
Binary Size ReportAffected SDKs
Test Logs
|
schmidt-sebastian
force-pushed
the
mrschmidt/newgetdocument
branch
from
51bf5a2 to
9be9cf6
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/newgetdocument
branch
from
9be9cf6 to
58a84d1
Compare
…sdk into mrschmidt/snapshot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.