Add setDoc() #3139
Merged
Add setDoc() #3139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irebase-js-sdk into mrschmidt/initializefirestore
This will be tested when getDoc() is added.
schmidt-sebastian
force-pushed
the
mrschmidt/setdoc
branch
from
8d1219c to
7649b67
Compare
…-sdk into mrschmidt/deletedoc
…sdk into mrschmidt/snapshot
rafikhan
approved these changes
Jun 3, 2020
Comment on lines
329
to
333
| const parsed = isMerge(options) | ||
| ? dataReader.parseMergeData('setDoc', convertedValue) | ||
| : isMergeFields(options) | ||
| ? dataReader.parseMergeData('setDoc', convertedValue, options.mergeFields) | ||
| : dataReader.parseSetData('setDoc', convertedValue); |
There was a problem hiding this comment.
Optional: I like the helper methods you made to interrogate the options but the ternary required effort to parse. Consider factoring this out into a helper function that includes the toMutations() call or perhaps convert this to a series of if/then/else.
There was a problem hiding this comment.
I have been bothered by this code for a while, as it is repeated in a couple of places in the SDK. I changed UserDataReader.parseSetData() to perform this check on behalf of the caller.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a lot of tests for existing code and a shared FieldValue class to be used by all SDK versions (comments inline that explain it).