Add WriteBatch #3152
Merged
Add WriteBatch #3152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irebase-js-sdk into mrschmidt/initializefirestore
This will be tested when getDoc() is added.
rafikhan
requested changes
Jun 4, 2020
Comment on lines
79
to
87
| const parsed = isMerge(options) | ||
| ? this._dataReader.parseMergeData('WriteBatch.set', convertedValue) | ||
| : isMergeFields(options) | ||
| ? this._dataReader.parseMergeData( | ||
| 'WriteBatch.set', | ||
| convertedValue, | ||
| options.mergeFields | ||
| ) | ||
| : this._dataReader.parseSetData('WriteBatch.set', convertedValue); |
There was a problem hiding this comment.
Same comment from a previous PR. Can you convert this to if/else or factor it out into a function?
rafikhan
approved these changes
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is much easier to review with the whitespace-ignored diff - https://github.com/firebase/firebase-js-sdk/pull/3152/files?w=1