Add terminate() to Lite SDK #3157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irebase-js-sdk into mrschmidt/initializefirestore
This will be tested when getDoc() is added.
schmidt-sebastian
requested review from
alikn,
andirayo,
avolkovi,
davideast,
erikeldridge,
Feiyang1,
hiranya911,
hsubox76,
jamesdaniels,
jsdt,
sam-gc,
scottcrossen,
yuchenshi,
zijianjoy and
zwu52
as code owners
schmidt-sebastian
changed the base branch from
mrschmidt/newgetdocument
to
master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the terminate logic to Datastore instead of FIrestore to ensure that WriteBatches cannot be committed after terminate is called.