Skip to content

Ignore lease refresh failures for single-tab clients #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

Ignore lease refresh failures for single-tab clients #3163

merged 1 commit into from
Jun 5, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jun 4, 2020 •
edited
Loading

We also need to ignore IndexedDB lease refresh failures for clients that don't opt into synchronizeTabs.

@thebrianchen This also removes an unused argument to updateClientMetadataAndTryBecomePrimary.

Addresses #2755

@schmidt-sebastian
Ignore lease refresh failures for single-tab clients
64111ab 
We also need to ignore IndexedDB lease refresh failures for clients that don't opt into synchronizeTabs.
@schmidt-sebastian schmidt-sebastian requested a review from wilhuff June 4, 2020 17:51
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (0395a1d) Head (856a90f) Diff
    browser 252 kB 252 kB -6 B (-0.0%)
    esm2017 195 kB 195 kB -12 B (-0.0%)
    main 494 kB 494 kB -40 B (-0.0%)
    module 249 kB 249 kB -6 B (-0.0%)

  • firebase

    Type Base (0395a1d) Head (856a90f) Diff
    firebase-firestore.js 290 kB 290 kB -4 B (-0.0%)
    firebase.js 823 kB 823 kB -4 B (-0.0%)

Test Logs

wilhuff
wilhuff approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Jun 5, 2020
@schmidt-sebastian schmidt-sebastian merged commit 0abf211 into master Jun 5, 2020
@firebase firebase locked and limited conversation to collaborators Jul 6, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/betterleaserefresh branch November 9, 2020 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wilhuff